Fix being unable to unboost when blocked by their author #14308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jul 14, 2020
Gargron
approved these changes
Jul 14, 2020
ClearlyClaire
force-pushed
the
fixes/blocked-unboost
branch
from
91a9b31
to
ae827f5
Compare
Gargron
approved these changes
Jul 14, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14307
The change is a bit awkward since the API returns a status when unboosting a toot. I decided to return the boosted toot anyway even if the author is blocked, since the booster, even though they are blocked, can already see the toot (through their profile, or list of boosted toots), and that by construction only applies to toots they have already seen and boosted.