Fix RSS feeds not being cachable #14368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only covers responses that we should have managed to make cachable so far. It's not the case of all responses that should be cachable in the end.
ClearlyClaire
force-pushed
the
fixes/cachable
branch
from
84afca5
to
e94d12a
Compare
ClearlyClaire
changed the title
Gargron
approved these changes
Jul 22, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
* Add tests for some cachable responses This only covers responses that we should have managed to make cachable so far. It's not the case of all responses that should be cachable in the end. * Fix RSS feeds not being cachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of responses that should be cachable but aren't.
Fundamentally, this mostly occurs because we're making use of sessions (and thus session cookies) when that is not strictly needed. Such occurrences are:
This PR adds tests to things that we have already made cachable, and fixes RSS feeds not being cachable.
Public HTML pages will require more work, if they're even possible to make cachable without loss of functionality.