Fix: also use custom private boost icon for detailed status #14471
Conversation
| @@ -20,6 +20,7 @@ export default class IconButton extends React.PureComponent { | |||
| style: PropTypes.object, | |||
| activeStyle: PropTypes.object, | |||
| disabled: PropTypes.bool, | |||
| privat: PropTypes.bool, | |||
There was a problem hiding this comment.
You probably meant private. And you really shouldn't pass this to shared IconButton component, there's a class name for that, I believe.
There was a problem hiding this comment.
No, private is a reserved word in JS.
It's similar to passing disabled as a class name. I believe this make the code structure more clear.
|
Because now custom icon is only used for I have seen ThibG's PR, but my PR is mainly for using custom private boost icon everywhere. |
diff
|
There was a problem hiding this comment.
Sorry for the late review! I concur with @Sasha-Sorokin, privat doesn't sound right. Also, I think it is far too specific to the boost icon to be part of IconButton's attributes, and should use className instead.
|
@Sasha-Sorokin @ThibG |
…#14471) * use custom private boost icon for detail status * only use className
…#14471) * use custom private boost icon for detail status * only use className
* use custom private boost icon for detail status * only use className
…#14471) * use custom private boost icon for detail status * only use className
#14380
If the custom icon for private boosts is accepted, it should be used everywhere.
By the way, this change can fix #14455