Add unread notification markers #14818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
features/notification-read-markers
branch
2 times, most recently
from
efa83ca
to
39461e6
Compare
ClearlyClaire
force-pushed
the
features/notification-read-markers
branch
from
39461e6
to
a6abf22
Compare
|
Pushed a change to EDIT: (this change has been made in glitch-soc for a while because we ran into the issue for other stuff) |
Gargron
approved these changes
Sep 26, 2020
thenameisnigel-old
pushed a commit
to ChatterlyOSE/Chatterly
that referenced
this pull request
Sep 28, 2020
* Add unread notification markers Fixes mastodon#14804 * Allow IntersectionObserverArticle's children to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14804
(This is a port of glitch-soc#1423)
Refactor and rework unread notifications handling. In particular, new notifications are not marked as read if any of the following doesn't hold:
If a new notification arrives when those conditions are met, or the user scrolls to the top and those conditions are met, then all notifications are marked as read.
Unread notifications are displayed with a highlighted border, as shown in the following image:
The display is only updated when the window/tab loses and regain visibility, or the tab is unmounted/remounted.
There is also a button to mark all notifications as read regardless of conditions.