Precise that home timeline filters also apply to lists #15139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Nov 10, 2020
|
I chose something shorter so it has approximately the same size as the other items and it doesn’t clutter the filters table but I’m not strongly opposed to your longer version. I feel that since the string contains “lists”, it’s clear we’re talking about columns. |
ariasuni
deleted the
precise-that-home-timeline-filters-applies-to-lists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s not obvious from a user point of view that filters on home also applies on lists.
I changed the English string “Home timeline” to “Home and lists”