Fix console error when scrolling a column with no scrollable content #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Apr 11, 2017
|
I would welcome any and all automated tests. But I must warn you that it's probably really complicated because of react-intl, redux and Immutable.js, like, there's a lot of boilerplate for setting up tests. |
Gargron
pushed a commit
that referenced
this pull request
Apr 12, 2017
thurloat
pushed a commit
to Moosetodon/mastodon
that referenced
this pull request
Apr 13, 2017
Nyoho
referenced
this pull request
in Nyoho/mathtodon
Apr 25, 2017
Nyoho
pushed a commit
to Nyoho/mathtodon
that referenced
this pull request
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of trying to get my feet wet here, with a fairly low-impact initial PR. Apologies if something this trivial is an unwanted kind of contribution at such a busy time!
The issue addressed by this PR is reproduced by clicking the header of a column that contains no content. For example: when you have no notifications. The lack of a
scrollableinside the column causes aTypeError: Cannot read property 'scrollTop' of nullerror.I've tested this change manually on a column both with and without content. In the long term, would you be at all interested in having unit tests for your front-end code? It's a gorgeous bit of React code and I could see myself having a lot of fun backfilling it with test coverage on some rainy evenings ❤️