Fix to be able to redownload avatar and header #16190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code hasn't been tested yet, but how about this approach? |
noellabo
force-pushed
the
fix-to-be-able-to-redownload-avatar-and-header
branch
from
e3a0b1e
to
ec30886
Compare
Gargron
approved these changes
May 9, 2021
noellabo
force-pushed
the
fix-to-be-able-to-redownload-avatar-and-header
branch
from
ec30886
to
43a0cfa
Compare
|
Looks like it's working. |
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
* Fix to reset if header and avatar download fails * Add RedownloadAvatarWorker and RedownloadHeaderWorker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15477 Take 2.
If the acquisition of avatar and header fails, the already acquired image will be discarded. This solves the problem that you can't update your avatar because you're holding the wrong image.
Perform RedownloadAvatarWorker and RedownloadHeaderWorker if you cannot get the avatar or header from the specified url due to a media server issue when updating your account information.
The Worker will retry 7 times. This is about a day. From the next day onward, when the account information is referenced, the old account information will be updated, so there will be a chance that the image will be updated again.