Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML formatting from portable contacts note. #1819

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2017

HTML isn't part of the portable contacts spec.

last available reference: https://web-beta.archive.org/web/20150923043617/http://portablecontacts.net:80/draft-spec.html

@Gargron
Copy link
Member

Gargron commented Apr 15, 2017

This change would break functionality. Linked entities in bios have been a requested and expected feature (and as always, formatting is a responsibility of the origin instance). I suggest adding a type="html" attribute on the <poco:note /> tag, it is part of the more general Atom spec: https://tools.ietf.org/html/rfc4287#section-3.1.1

@ghost
Copy link
Author

ghost commented Apr 15, 2017

Unfortunately that doesn't solve the issue as poco:note isn't allowed to be HTML regardless of whether the encapsulating document allows it or not in other fields. Could you use the Summary element instead? You can use HTML there without breaking the spec.

http://activitystrea.ms/specs/atom/1.0/#atom.object.components
http://activitystrea.ms/specs/atom/1.0/#rfc.section.2.1.7

@1337god
Copy link

1337god commented Apr 19, 2017

+1

Gargron added a commit that referenced this pull request Apr 21, 2017
@Gargron Gargron closed this in 9d3be55 Apr 22, 2017
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017
* Fix mastodon#1057 (close mastodon#1819) - Move HTML-formatted bio from <poco:note /> to <summary type="html" />

* Ensure <poco:note /> is plaintext for remote accounts, also, by stripping out HTML
tribela pushed a commit to tribela/mastodon that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants