Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post status idempotency - prevent duplicates from network failures #2419

Merged
merged 2 commits into from Apr 25, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Apr 25, 2017

Fix #2402 - Add Idempotency-Key header to PostStatusService that prevents duplicates. Web UI regenerates UUID for that header every time the compose form is changed or successfully submitted

Also, fix Farsi i18n overwriting the English one

…ents

duplicates. Web UI regenerates UUID for that header every time the compose
form is changed or successfully submitted

Also, fix Farsi i18n overwriting the English one
@@ -1,5 +1,5 @@
---
en:
fa:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky, thanks for the fix 👍

Copy link
Member

@ineffyble ineffyble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds have passed, so this shouldn't break anything. I haven't tested this myself, but the concept is good, and I can't see any obvious code errors.

@Gargron Gargron merged commit 8b5179d into master Apr 25, 2017
@Gargron Gargron deleted the feature-idempotency branch April 25, 2017 13:04
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 26, 2017
…hat prevents (mastodon#2419)

duplicates. Web UI regenerates UUID for that header every time the compose
form is changed or successfully submitted

Also, fix Farsi i18n overwriting the English one
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017
…hat prevents (mastodon#2419)

duplicates. Web UI regenerates UUID for that header every time the compose
form is changed or successfully submitted

Also, fix Farsi i18n overwriting the English one
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idempotency header for new status creation
3 participants