New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Capfile (remove capistrano/faster_assets) #2737

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
3 participants
@esetomo
Contributor

esetomo commented May 3, 2017

capistrano/faster_assets has been removed from Gemfile, but it remains in Capfile.

@esetomo

This comment has been minimized.

Contributor

esetomo commented May 3, 2017

after fix Capfile, another error on deploy:assets:precompile.

Webpacker is installed 🎉 🍰
Using /home/mastodon/app/releases/20170503081937/config/webpack/paths.yml file for setting up webpack paths
Compiling webpacker assets 🎉
/home/mastodon/app/shared/~/css-loader?{"minimize":true}!/home/mastodon/app/shared/~/postcss-loader!/home/mastodon/app/shared/~/sass-loader/lib/loader.js!/home/mastodon/app/shared/~/font-awesome/css/font-awesome.css
Module build failed: Error: No PostCSS Config found in: /home/mastodon/app/shared/node_modules/font-awesome/css
    at /home/mastodon/app/shared/node_modules/postcss-load-config/index.js:51:26
 @ /home/mastodon/app/shared/~/font-awesome/css/font-awesome.css 4:14-143
 @ ./app/javascript/packs/application.js
/home/mastodon/app/shared/~/font-awesome/css/font-awesome.css
Module build failed: ModuleBuildError: Module build failed: Error: No PostCSS Config found in: /home/mastodon/app/shared/node_modules/font-awesome/css
    at /home/mastodon/app/shared/node_modules/postcss-load-config/index.js:51:26
    at runLoaders (/home/mastodon/app/shared/node_modules/webpack/lib/NormalModule.js:192:19)
    at /home/mastodon/app/shared/node_modules/loader-runner/lib/LoaderRunner.js:364:11
    at /home/mastodon/app/shared/node_modules/loader-runner/lib/LoaderRunner.js:230:18
    at context.callback (/home/mastodon/app/shared/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /home/mastodon/app/shared/node_modules/postcss-loader/index.js:148:13

workaround:
$ echo 'module.exports = {};' > /:deploy_to/shared/postcss.config.js

@mjankowski

Is there any sort of capistrano linter or check we could have had in place which would catch this on CI?

@Gargron Gargron merged commit 24a5d13 into tootsuite:master May 3, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@esetomo esetomo deleted the esetomo:remove-faster-assets-from-capfile branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment