Fix color contrast some more in privacy warning #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest master appears to have changed the <strong> to this unreadable grey color. If you want that to be white then it should be pure white. If someone would rather revert this to that strong dark blue color it was before that would be good too.
|
It was never meant to be white, I am not sure what change did this |
|
Just make it |
|
It's done. |
|
I was about to make the same PR, I'm glad I found this one before. |
Gargron
approved these changes
May 12, 2017
Gargron
requested changes
May 12, 2017
| @@ -236,7 +236,7 @@ | |||
| font-weight: 400; | |||
|
|
|||
| strong { | |||
| color: darken($primary-text-color, 33%); | |||
| color: darken($ui-secondary-color, 65%) | |||
There was a problem hiding this comment.
woops! that's what i get for copy-pasting
woops
|
OK! +; |
|
At least can you provide a screen on how it renders now? This is how my proposition renders (but it's custom CSS) : |
Gargron
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest master appears to have changed the
<strong>to this unreadable grey color.So this PR makes it look like this:
If you want that to be white then it should be pure white. If someone would rather revert this to that strong dark blue color it was before that would be good too.