Remove status context construction in the React side #3331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it may causes flicker on the conversation when it contains blocked/muted user's status.
We use
/api/v1/statuses/{id}/context
to obtain status ids in the conversation which filters blocked/muted user, but also uses internal cache mainly constructed fromin_reply_to_id
in thereducers/timelines.js
which doesn't filter.So if the non-API context cache exists, statuses will appear in conversation even those statuses are from blocked/muted user. Then those statuses will be removed when the context cache are updated with the context API.
I have left the
normalizeStatus()
function itself which is called many functions in the file as a placeholder for now, but maybe it should be removed completely.Note: This issue won't happen on v1.3 or earlier, because filtering on the context API is fixed with the domain block feature in 1.4.