Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread indicator was invisible behind column header, adjusted #3720

Merged
merged 3 commits into from Jun 12, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jun 12, 2017

image

@unarist
Copy link
Contributor

unarist commented Jun 12, 2017

It may be invisible, or may be visible on weird position (#3711).

And the indicator seems to move according to scroll, so changing top value won't fix this. I've tested on Chrome 59 on Windows.

@Gargron
Copy link
Member Author

Gargron commented Jun 12, 2017

@unarist Thank you for reporting. It behaves correctly on Firefox. I don't currently have Chrome to experiment with this. If you inspect the element, do you have any idea why it would behave that way instead of sticking to the .column which is position: relative? It should be position: absolute relative to .column. But what you are saying sounds like it's relative to some child element of .column like .scrollable.

@unarist
Copy link
Contributor

unarist commented Jun 12, 2017

@Gargron I've also confirmed that it works on Firefox...

sounds like it's relative to some child element of .column like .scrollable.

I think so too.

Sadly, I haven't found CSS solution yet and I thought the only way to fix this is move the indicator to outside of the scrollable container.

@Gargron
Copy link
Member Author

Gargron commented Jun 12, 2017

That sounds reasonable, I will try to do that

@Gargron
Copy link
Member Author

Gargron commented Jun 12, 2017

@unarist I have tried

Copy link
Contributor

@unarist unarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@unarist
Copy link
Contributor

unarist commented Jun 12, 2017

Oh wait, could you add flex: 0 0 auto to .column-header__wrapper and remove from .column-collapsable? This style is needed for sibling elements of large flex-item. It was .column-collapsable, but it's .column-header__wrapper now. (c.f. #3313)

@Gargron Gargron merged commit 37dbfa4 into master Jun 12, 2017
@Gargron Gargron deleted the fix-unread-indicator branch June 12, 2017 18:02
koteitan pushed a commit to koteitan/mastodon that referenced this pull request Jun 25, 2017
…on#3720)

* Unread indicator was invisible behind column header, adjusted

* Unread indicator now a CSS pseudo-element

* Adjust flex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants