Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid async import if the component is previously loaded #4127

Merged
merged 1 commit into from
Jul 9, 2017
Merged

Avoid async import if the component is previously loaded #4127

merged 1 commit into from
Jul 9, 2017

Conversation

unarist
Copy link
Contributor

@unarist unarist commented Jul 9, 2017 •
edited

Before

image

After

image

This avoids flashing of loading view and slightly reduces total time.

cc @sorin-davidoi

@unarist unarist added performance Runtime performance ui Front-end, design labels Jul 9, 2017
@Gargron Gargron merged commit caf9385 into mastodon:master Jul 9, 2017
rtucker pushed a commit to vulpineclub/mastodon that referenced this pull request Jul 10, 2017
@unarist @rtucker
Avoid async import if the component is previously loaded (mastodon#4127)
ccee3c9
@unarist unarist mentioned this pull request Jul 23, 2017
Closed
@unarist unarist deleted the avoid-async-load branch September 30, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
performance Runtime performance ui Front-end, design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unarist @Gargron