fix(components/media_modal): Aspect ratio #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unarist
reviewed
Jul 9, 2017
| @@ -1281,6 +1281,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| .media-modal .react-swipeable-view-container { | |||
| align-items: center; | |||
There was a problem hiding this comment.
Is not this line superseded by animateHeight option?
(btw, I like align-items: center way since height animation doesn't look good for me, at least for now)
There was a problem hiding this comment.
Right, but it's superseded by opacity: 0 (did not know how else to position the canvas behind the image).
|
I'm worried about vertical moving on switching between different aspect ratios, but I don't have ideas yet... GIF
|
Gargron
approved these changes
Jul 9, 2017
|
@unarist That gif looks pretty cool to me? Except that it seems a part of the old image is visible on the very left? |
|
@unarist We could just use the old package ( |
|
Maybe no one cares about it except me :) |
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jul 10, 2017
* fix(components/media_modal): Aspect ratio * fix: Remove useless style
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jul 10, 2017
* fix(components/media_modal): Aspect ratio * fix: Remove useless style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit over my head with the CSS here. This should fix the issues mentioned by @unarist in #2889.