Remote following success page #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes follow-through links to web (the old redirect target) and back to the remote user's profile
Gargron
reviewed
Jul 10, 2017
| @@ -94,7 +94,7 @@ | |||
| end | |||
|
|
|||
| it 'follows account when found' do | |||
| target_account = double(id: '123') | |||
| target_account = Account.new | |||
There was a problem hiding this comment.
You can use Fabricate(:account), please see other tests for examples.
Gargron
reviewed
Jul 10, 2017
config/locales/en.yml
Outdated
| @@ -218,6 +218,12 @@ en: | |||
| authorize_follow: | |||
| error: Unfortunately, there was an error looking up the remote account | |||
| follow: Follow | |||
| following_html: 'Success! You (<strong>%{self}</strong>) are now following:' | |||
There was a problem hiding this comment.
It is probably not necessary to specify self in these two strings because the user just clicked from a page that already did that.
There was a problem hiding this comment.
I was trying to keep the two pages looking similar in style, but now that I think about it, you're probably right.
(and all HTML with it)
Gargron
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of immediately redirecting to web upon doing a remote follow, show an interstitial success page with links to web (the same redirect as before), and a link back to the remote user's profile, while also saying it's safe to close the page.
Personally, I keep my instance open in a pinned tab all the time but I prefer using the remote follow button to follow people over copying and pasting URLs around. Having remote follows automatically redirect to web was rather annoying since I would already have it open somewhere else.
Preview of how it looks:
