Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer tab according to column #4135

Merged
merged 3 commits into from
Jul 11, 2017
Merged

Drawer tab according to column #4135

merged 3 commits into from
Jul 11, 2017

Conversation

ykzts
Copy link
Sponsor Member

@ykzts ykzts commented Jul 10, 2017

Add a link to the notifications to the drawer when there is no notification in columns.

has notifications column

doesn't has notifications column

@ykzts ykzts added the ui Front-end, design label Jul 10, 2017
@beatrix-bitrot
Copy link
Contributor

I like it!

@Gargron
Copy link
Member

Gargron commented Jul 11, 2017

I think it would be a bit inconsistent if the public/local icons are always on but only notifications is conditional.

@ykzts
Copy link
Sponsor Member Author

ykzts commented Jul 11, 2017

@Gargron Certainly. I changed it.

add all colums

remove all columns

@beatrix-bitrot
Copy link
Contributor

the home column can also be un-pinned. will it show there if it is?

@ykzts
Copy link
Sponsor Member Author

ykzts commented Jul 11, 2017

@beatrix-bitrot I add 🏠

@ykzts ykzts changed the title Add notifications link to drawer Drawer tab according to column Jul 11, 2017
@Gargron Gargron merged commit 3136633 into mastodon:master Jul 11, 2017
@ykzts ykzts deleted the notifications branch July 11, 2017 12:49
@beatrix-bitrot
Copy link
Contributor

thanks @ykzts !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants