Update es5-ext to avoid CSP violation #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since es5-ext used `new Function("...")`, it caused CSP violation unless "unsafe-eval" included. So this patch updates it to the version which fixes it.
Note that this package is used in polyfills, so loaded only if needed. I've encountered this issue on iOS9.
cf. medikoo/es5-ext@d3864493
Gargron
approved these changes
Jul 10, 2017
|
This might also improve things for #2760. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since es5-ext used
new Function("..."), it caused CSP violation unless "unsafe-eval" included. So this patch updates it to the version which fixes it.Note that this package is used in polyfills (e.g. Symbol), so loaded only if needed. I've encountered this issue on iOS9.
cf. medikoo/es5-ext@d3864493