feat: Enable push subscription for mobile devices by default #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorin-davidoi
commented
Jul 23, 2017
| @@ -16,10 +16,23 @@ def create | |||
| active_session.update!(web_push_subscription: nil) | |||
| end | |||
|
|
|||
| # Mobile devices do not support regular notifications, so we enable push notifications by default | |||
| alerts_enabled = active_session.detection.device.mobile? || active_session.detection.device.tablet? | |||
There was a problem hiding this comment.
This is basically Chrome and Firefox on Android.
Gargron
approved these changes
Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile devices do not support regular notifications. So we enable push notifications by default for these devices. I wish there was a better way to detect this, but it is impossible to reliably feature-detect this in the browsers (e.g. Chrome exposes the Notification API but throws errors when invoked).