Fix Paperclip::Fog always responds Not Found in some OpenStack-v2 #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Sep 30, 2017
rutan
pushed a commit
to rutan/mastodon
that referenced
this pull request
Oct 11, 2017
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2322 was made for OpenStack-v2 (c.f. ConoHa) but #4889 removed 'openstack_tenant' for v3.
That causes the problem as the title of this PR.
In detail of this issue:
In addition, this PR replaces to 'fetch' because 'fog_host' is not required parameter according to Paperclip comment.
I don't know that Mastodon supports any OpenStack-v2, so if no intention to do that, then feel free to close this.