Fix account URI when updating ActivityPub account #7488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
May 14, 2018
|
I've never had such a quick reply for a PR, @Gargron are you running a review bot? :-) |
|
No but you changed one line, explained what you were doing, and you are closing a bug report. I suppose the only way this PR could be better if you included the string "Fix #7479" anywhere in commit message or PR body so the bug would be automatically closed when this is merged. |
|
Good idea, let me replace this commit in a minute... |
Updates account `uri` field on each call to `update_account` instead of only once during `create_account` to mirror the same behavior in OStatus `ResolveAccountService` class [0]. ActivityPub accounts are identified using `@username` and `@domain` pair instead of URI since mastodon#6842. This fixes mastodon#7479: a bug when the account identified by `@username` and `@domain` changes its URI. [0]: https://github.com/tootsuite/mastodon/blob/03b69ebc450efc07246bd64204276941b7ede3fc/app/services/resolve_account_service.rb#L121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates account
urifield on each call toupdate_accountinstead of only once duringcreate_accountto mirror the same behavior in OStatusResolveAccountServiceclass.ActivityPub accounts are identified using
@usernameand@domainpair instead of URI since #6842.This fixes a bug when the account identified by
@usernameand@domainchanges its URI (#7479).