Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder simple form ul to list vertically (fixes #8236) #8322

Merged
merged 2 commits into from Aug 20, 2018
Merged

reorder simple form ul to list vertically (fixes #8236) #8322

merged 2 commits into from Aug 20, 2018

Conversation

NecroTechno
Copy link
Contributor

@NecroTechno NecroTechno commented Aug 20, 2018

Modified the filter languages list so that they are listed alphabetically vertically rather than horizontally.

screenshot from 2018-08-20 20-31-45

@Cassolotl
Copy link

Are they sorted by their name in English rather than the visible name? Because Bahasa Indonesia comes after Magyar, and Suomi comes before Français! That doesn't seem right. (It's better than it was though.)

width: 50%;
ul {
columns: 2;
-webkit-columns: 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and below is not necessary, we have autoprefixer generating these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. I've updated this now.

@NecroTechno
Copy link
Contributor Author

@Cassolotl it's currently sorted by the language's ISO 639-1 code. For example, Bahasa Indonesia comes just before Italiano as their ISO 639-1 codes are "id" and "it" respectively.

I definitely understand the desire to order it purely alphabetically, but I'm conscious of both:

  1. changes to the existing functionality of displaying the localised names of the languages and
  2. ordering it alphabetically as to group languages with non-basic latin letters together.

Honestly, I'm not really sure how else to tackle that particular problem.

@Gargron Gargron merged commit 6a0d4d3 into mastodon:master Aug 20, 2018
@Cassolotl
Copy link

@NecroTechno Alright, thanks for the explanation. :) It's better than it was before, so I'm into it! Thanks for working on this.

@NecroTechno NecroTechno deleted the language-filter-reorder branch August 20, 2018 22:38
@trwnh
Copy link
Member

trwnh commented Aug 21, 2018

Yeah, like I said in #8236 (comment), "Suomi" is technically "Finnish", so that's why it comes before "Français" (and after "Farsi"). :)

kyori19 pushed a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018
…odon#8322)

* reorder simple form ul to list vertically (fixes mastodon#8236)

* remove browser specific prefixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants