Exclude replies from list timelines #8683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the following line to the FeedManager (app/lib/feed_manager.rb) in the push_to_list function: `return false if status.reply?` Now all posts that are replies are filtered out, so that now only "genuine" posts are displayed in the list. This is a first approach to solve issue mastodon#5916
Gargron
requested changes
Sep 27, 2018
As suggested by @Gargron
Gargron
approved these changes
Sep 27, 2018
ht164
added a commit
to ht164/mastodon
that referenced
this pull request
Nov 4, 2018
This reverts commit 4b78546.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small tweak in list behaviour: Now all posts that are replies are filtered out, so that now only "genuine" posts are displayed in the list.
Of course this is a bit sub-optimal in that it would be better to have a certain subset of these replies - namely those on posts whose authors are also list members. But filtering that requires a bit more complex logic.
One would have to find the post to which the reply relates. Then seek the author of this post and then a comparison, if they are a list member.
The best way would be to provide the user with a setting which gives them an option to choose whether the want the "old" or "new" behavior.
This is a first approach to solve issue #5916