Replace "elephant_ui_plane.svg" asset with Custom mascot

[shleeable]

This is my first pass of this feature patch... I'm new to Ruby.. I'll test and patch bugs tonight.

[shleeable]

There is a hardcoded path for the file in

/Users/shlee/Documents/GitHub/mastodon/app/javascript/styles/mastodon/modal.scss
18,32: background: url('../images/elephant_ui_plane.svg') no-repeat left bottom / contain;

and

/Users/shlee/Documents/GitHub/mastodon/app/javascript/mastodon/features/compose/index.js
15,46: import elephantUIPlane from '../../../images/elephant_ui_plane.svg';

but I don't understand how to make them dynamic yet.

[MaciekBaron]

Maybe I'm a bit nitpicky but could we squash these commits into one?

[shleeable]

Maybe I'm a bit nitpicky but could we squash these commits into one?

I need to get my head around git - I'd assume this would be squashed at merge? or can I squash them before hand?

Update: steps below worked as expected. I'll aim to keep future PRs in similar condition.

[MaciekBaron]

The merge would bring all your commits into master.

The easiest way would probably be running:

git reset --soft HEAD~7
git commit -m "Replace SVG asset with Custom mascot"

And then doing a force push to your branch (with -f). This why we have one, nicely labelled commit that explains your change in the log.

[Gargron]

One thing that comes to mind is, if you're planning to make all mascots customizable, naming the setting "mascot" is not going to age well. On the other hand... There are really a lot of elephants in the UI. If only some can be configured, it's going to be an inconsistency, but if you're going to customize all of them, that's a big mess too. I'm not sure if that can of worms should be opened at all?

[shleeable]

@Gargron mascot was used because that's the common reference in the code - but I understand it could be confusing.. Maybe it's better to talk about goals - I want to change this dude every now and then. as mentioned in #8525

Is your recommendation to edit the hardcoded paths/css directly and rebuild? this means I'm git stashing a few extra files or making a few extra modifications to a few extra files every upgrade.

The cleaner option might be expanding the official documentation with the recommend practices to modify there things.

[shleeable]

but if you're going to customize all of them, that's a big mess too. I'm not sure if that can of worms should be opened at all?

If you DO want to go down that path - maybe we need to move theming into it's own menu in administration.

right now... I'd be interested in quick/easy replacement for

Image based theming

• favicon
• Large Logo (TOP)
• Small Logo (Middle)
• Hero image (already tweakable)
• Mascot dude (Corner)
• Instance thumbnail (unseen)

but mascot dude is the only one I truly care about

[nightpool]

@MaciekBaron @ashleyhull-versent we always squash PRs when merging them, so it's not very important to do so ahead of time.

[MayMeow]

is there any way to revert customized mascot back to default one?