Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: fix margins: public-layout.header.nav-button #8823

Merged
merged 2 commits into from Sep 29, 2018

Conversation

@mabkenar
Copy link
Contributor

commented Sep 28, 2018

Before:
selection_576

After:
selection_578

Please test it though, since I haven't tested if rtl.css is loaded at all for public pages.

With the new public page design, text direction for individual RTL toots is also wrong (this is the old #2350, re-opened). But I can't figure out how to fix it.

mabkenar added 2 commits Sep 28, 2018
@ykzts ykzts added bug ui i18n labels Sep 29, 2018
@ykzts
ykzts approved these changes Sep 29, 2018
@ykzts ykzts merged commit df2f405 into tootsuite:master Sep 29, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@mabkenar mabkenar deleted the mabkenar:patch-2 branch Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.