Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation dialog when hitting reply and the compose box isn't empty #8893

Merged
merged 2 commits into from Oct 5, 2018

Conversation

@ThibG
Copy link
Collaborator

commented Oct 5, 2018

Fixes #878

@ThibG ThibG force-pushed the ThibG:features/reply-confirmation branch from e693833 to 6d58402 Oct 5, 2018
@ThibG ThibG force-pushed the ThibG:features/reply-confirmation branch from e35359d to 02284a5 Oct 5, 2018
@ThibG ThibG removed the work in progress label Oct 5, 2018
@@ -71,6 +72,7 @@ class Status extends ImmutablePureComponent {
'account',
'muted',
'hidden',
'askReplyConfirmation',

This comment has been minimized.

Copy link
@ThibG

ThibG Oct 5, 2018

Author Collaborator

Thinking about it, I'm not too sure about the performance implications of this. Maybe the mapDispatchToProps thing should be rewritten instead to use getState.

@kit-ty-kate

This comment has been minimized.

Copy link

commented Oct 5, 2018

Thanks!! <3

@ThibG ThibG force-pushed the ThibG:features/reply-confirmation branch from 10ed8b9 to 436a8b0 Oct 5, 2018
@ykzts
ykzts approved these changes Oct 5, 2018
@Gargron Gargron merged commit 42aecb4 into tootsuite:master Oct 5, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@ThibG ThibG deleted the ThibG:features/reply-confirmation branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.