Do not push DMs into the home feed #8940
Conversation
|
I'm not sure this makes 100% sense, because aren't those direct posts still technically replies to something? I like having my home feed show the people I'm following, including their direct posts to me. It might be fine if they were filtered out only when the DM column is pinned, like with the notification column. And of course, it'd be best as an option. |
Are you saying that if I unpin the notifications column, notifications will show up in my home feed? Is this true? |
|
@nightpool No, I meant that DMs are made to not show in the notification column when the DM column is pinned. Sorry for any confusion |
|
This is excellent... I keep having the fear that I'm going to accidentally reply to a public toot thinking it's a DM. ;) |
Gargron
force-pushed
the
fix-remove-dms-from-home
branch
from
82f5c8a
to
95fcbb1
Compare
| @@ -11,6 +13,7 @@ const initialState = ImmutableMap({ | |||
| items: ImmutableList(), | |||
| isLoading: false, | |||
| hasMore: true, | |||
| mounted: false, | |||
There was a problem hiding this comment.
This is slightly confusing as mounted is used as a number below.
| render_anonymous_payload(status) | ||
|
|
||
| if status.direct_visibility? | ||
| deliver_to_mentioned_followers(status) | ||
| deliver_to_direct_timelines(status) |
There was a problem hiding this comment.
This means the old API won't be able to access newer direct toots. I thought we could have some transition period before dropping that?
And remove highlighting in web UI Full circle from #8940
…astodon#14711) And remove highlighting in web UI Full circle from mastodon#8940
…astodon#14711) And remove highlighting in web UI Full circle from mastodon#8940
This is a UX-oriented change. With conversations API, DMs now feel a lot more like DMs. Having them in the home timeline has always been a little strange and unnecessary.
Furthermore, we need to improve support for restricted-audience posts, i.e. private posts where not all followers are allowed to see it, but only an explicit list of recipients. From protocol view, that looks the same as a DM, but from the UX view, those are the posts that would need to be in the home feed. So this PR is a clean up in preparation for that.