Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement adding a user to a list from their profile #9062
Conversation
This comment has been minimized.
This comment has been minimized.
need to fix css? |
This comment has been minimized.
This comment has been minimized.
You need to:
|
Gargron
changed the title
Add add user to list from thier profile
Implement adding a user to a list from their profile
Oct 23, 2018
Gargron
added
the
ui
label
Oct 23, 2018
This comment has been minimized.
This comment has been minimized.
・・・Error?Why? |
This comment has been minimized.
This comment has been minimized.
Seems unrelated to you, the 2.5 ruby tests passed. |
This comment has been minimized.
This comment has been minimized.
Is there any chance you can take a screenshot and put it in the description? |
This comment has been minimized.
This comment has been minimized.
I skipped the word " in the description" and was delayed in fixing it. |
This comment has been minimized.
This comment has been minimized.
Did you have any problems with this patch? |
Gargron
approved these changes
Nov 2, 2018
Gargron
merged commit bb5558d
into
tootsuite:master
Nov 5, 2018
11 checks passed
ci/circleci: build
Your tests passed on CircleCI!
Details
ci/circleci: check-i18n
Your tests passed on CircleCI!
Details
ci/circleci: install
Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3
Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4
Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5
Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3
Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4
Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5
Your tests passed on CircleCI!
Details
ci/circleci: test-webui
Your tests passed on CircleCI!
Details
codeclimate
All good!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
namelessGonbai commentedOct 23, 2018
•
edited
Fix #6058
Add it only when you are following the "Add or Remove from Lists" button on the menu of the account


and add it to the list along with the option of creating a new list on the new ListAdder Modal screen created referring to ListEditor.
ListAdder's name is miserable, but I had no sense of naming. Also, since there is no experience of CSS or HTML <div> structure, I am worried about whether I could do it properly.
I used Javascript and css for the first time as I really wanted this function.
I tried as much as I could but please let me know if there is any problem.