New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adding a user to a list from their profile #9062

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@namelessGonbai
Copy link
Contributor

namelessGonbai commented Oct 23, 2018

Fix #6058 

Add it only when you are following the "Add or Remove from Lists" button on the menu of the account
SampleOfAccountMenu
and add it to the list along with the option of creating a new list on the new ListAdder Modal screen created referring to ListEditor.
SampleOfModal
ListAdder's name is miserable, but I had no sense of naming. Also, since there is no experience of CSS or HTML <div> structure, I am worried about whether I could do it properly.

I used Javascript and css for the first time as I really wanted this function.
I tried as much as I could but please let me know if there is any problem.

@namelessGonbai

This comment has been minimized.

Copy link
Contributor Author

namelessGonbai commented Oct 23, 2018

need to fix css?
Do I need close this PR?

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Oct 23, 2018

You need to:

  1. Remove trailing whitespace from the css file
  2. Replace hardcoded hex color values with SCSS variables defined in variables.scss (with darken/lighten, see how it's done in other components)

@Gargron Gargron changed the title Add add user to list from thier profile Implement adding a user to a list from their profile Oct 23, 2018

@Gargron Gargron added the ui label Oct 23, 2018

@namelessGonbai

This comment has been minimized.

Copy link
Contributor Author

namelessGonbai commented Oct 23, 2018

・・・Error?Why?

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Oct 23, 2018

Seems unrelated to you, the 2.5 ruby tests passed.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Oct 23, 2018

Is there any chance you can take a screenshot and put it in the description?

@namelessGonbai

This comment has been minimized.

Copy link
Contributor Author

namelessGonbai commented Oct 23, 2018

I skipped the word " in the description" and was delayed in fixing it.

@namelessGonbai

This comment has been minimized.

Copy link
Contributor Author

namelessGonbai commented Nov 1, 2018

Did you have any problems with this patch?

@Gargron

Gargron approved these changes Nov 2, 2018

@Gargron Gargron merged commit bb5558d into tootsuite:master Nov 5, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment