Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove character counter from edit profile #9100

Merged
merged 3 commits into from Oct 25, 2018

Conversation

@Gargron
Copy link
Member

commented Oct 25, 2018

HTML in translation is bad enough given that many translators on Weblate cannot code, but here it's also pluralized, creating issues like #9088. Instead, why not simply limit the input with maxlength? It's less upfront, but I also think that editing display name / bio comes up less often.

@Gargron Gargron added the ui label Oct 25, 2018
@ykzts
ykzts approved these changes Oct 25, 2018
@Gargron Gargron merged commit 161aead into master Oct 25, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@Gargron Gargron deleted the fix-remove-profile-counter-hint branch Oct 25, 2018
cyber-gene added a commit to ikebuku-ro/mastodon that referenced this pull request Oct 26, 2018
* 'master' of github.com:tootsuite/mastodon:
  Fix missing `mention` argument when processing incoming Create activities (tootsuite#9114)
  Skip link-back check if body is nil (tootsuite#9107)
  Remove character counter from edit profile (tootsuite#9100)
  Fix direct messages column not loading more items on scroll (tootsuite#9102)
  Fix conversations not being marked read on click (tootsuite#9103)
  Do not fetch preview card for mentioned users (tootsuite#6934)
  Allow inbox owner to view implicitly targeted ActivityPub payload (tootsuite#9093)
  cli: set exit_on_failure for all CLI classes (tootsuite#9094)
@nightpool

This comment has been minimized.

Copy link
Collaborator

commented Oct 27, 2018

hmm. I think this was a bad idea. we need to fix plurals on weblate, and now we have a check for them. there's no reason to think that avoiding plurals alltogether will help

@barzamin

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2018

strongly support @nightpool fwiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.