Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include preview cards in status entity in REST API #9120

Merged
merged 3 commits into from Oct 28, 2018

Conversation

@Gargron
Copy link
Member

commented Oct 27, 2018

Fix #1495
Fix #7208

image

A link can sometimes be fetched before the status is distributed. In other cases, first distribution includes no card. However, with the preview card resetting the cache of its status, the card will appear on subsequent loads. This might be acceptable.

When used from the in-stream status component, the card uses "compact" styling, which omits the description of the link and enforces a single-line rule for titles, and shrinks the thumbnail to 60px width, unless the preview is interactive. When the preview is interactive (e.g. YouTube), the thumbnail with action buttons is shown at 16:9, with no description section and no border.

@Gargron Gargron added the ui label Oct 27, 2018

@ykzts
ykzts approved these changes Oct 27, 2018

@Gargron Gargron force-pushed the feature-cards-in-stream branch from ac77ed7 to 57d1ccc Oct 28, 2018

@Gargron Gargron merged commit 795f010 into master Oct 28, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-cards-in-stream branch Oct 28, 2018

cyber-gene pushed a commit to ikebuku-ro/mastodon that referenced this pull request Oct 29, 2018
cybergene cybergene
Merge branch 'master' of github.com:tootsuite/mastodon
* 'master' of github.com:tootsuite/mastodon: (23 commits)
  Bump version to 2.6.0rc3 (tootsuite#9142)
  Update AUTHORS.md (tootsuite#9141)
  Bump sanitize from 4.6.6 to 5.0.0 (tootsuite#9140)
  Update i18n-tasks to master (tootsuite#9139)
  Improved grammar in German translation (tootsuite#9092)
  Add Page AP type support (tootsuite#9121)
  Weblate translations (2018-10-26) (tootsuite#9113)
  Bump parallel_tests from 2.25.0 to 2.26.0 (tootsuite#9137)
  Bump tzinfo-data from 1.2018.6 to 1.2018.7 (tootsuite#9136)
  Bump rubocop from 0.59.2 to 0.60.0 (tootsuite#9135)
  Bump doorkeeper from 5.0.1 to 5.0.2 (tootsuite#9134)
  Fix dimensions of preview cards, fix crash in web UI, fix warning (tootsuite#9133)
  Update i18n-tasks and change CircleCI command (tootsuite#9104)
  Reset status cache when status_stat or media_attachment updates (tootsuite#9119)
  Add progress indicators to MigrateAccountConversations (tootsuite#9101)
  Set z-index of dropdown to 9999. (tootsuite#9126)
  Include preview cards in status entity in REST API (tootsuite#9120)
  Do not remove "dead" domains in tootctl accounts cull (tootsuite#9108)
  When searching for an emoji with multiple separators, consider the full input (tootsuite#9124)
  Add locality check to ActivityPub::FetchRemoteAccountService (tootsuite#9109)
  ...
cyber-gene pushed a commit to ikebuku-ro/mastodon that referenced this pull request Oct 29, 2018
cybergene cybergene
Merge commit 'e84da282f6331d463678a7e3ccd37e66c0dfcab3' into production
* commit 'e84da282f6331d463678a7e3ccd37e66c0dfcab3': (34 commits)
  Bump version to 2.6.0rc3 (tootsuite#9142)
  Update AUTHORS.md (tootsuite#9141)
  Bump sanitize from 4.6.6 to 5.0.0 (tootsuite#9140)
  Update i18n-tasks to master (tootsuite#9139)
  Improved grammar in German translation (tootsuite#9092)
  Add Page AP type support (tootsuite#9121)
  Weblate translations (2018-10-26) (tootsuite#9113)
  Bump parallel_tests from 2.25.0 to 2.26.0 (tootsuite#9137)
  Bump tzinfo-data from 1.2018.6 to 1.2018.7 (tootsuite#9136)
  Bump rubocop from 0.59.2 to 0.60.0 (tootsuite#9135)
  Bump doorkeeper from 5.0.1 to 5.0.2 (tootsuite#9134)
  Fix dimensions of preview cards, fix crash in web UI, fix warning (tootsuite#9133)
  Update i18n-tasks and change CircleCI command (tootsuite#9104)
  Reset status cache when status_stat or media_attachment updates (tootsuite#9119)
  Add progress indicators to MigrateAccountConversations (tootsuite#9101)
  Set z-index of dropdown to 9999. (tootsuite#9126)
  Include preview cards in status entity in REST API (tootsuite#9120)
  Do not remove "dead" domains in tootctl accounts cull (tootsuite#9108)
  When searching for an emoji with multiple separators, consider the full input (tootsuite#9124)
  Add locality check to ActivityPub::FetchRemoteAccountService (tootsuite#9109)
  ...
TheInventrix added a commit to TheInventrix/mastodon that referenced this pull request Dec 28, 2018
TheInventrix added a commit to TheInventrix/mastodon that referenced this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.