Ensure replied-to is a status not a boost #9129
Conversation
|
so, suggestion, do the same thing reblogs do, so this isn't just fixed on the API side but on the federation side too: (it's also less code :P) |
|
I thought it's the same thing, I just put it in the creation service instead of a pre-save macro. You say this belongs in the model instead? |
|
it's not the same thing. I can still send a s2s |
|
That's my lack of understanding then. Gonna adjust. |
|
Moved to model. |
|
@nightpool @ThibG Thoughts? I'm not sure replying to boosts is a bug, we certainly aren't taking advantage of it in the UI, but I'm not sure if we never will. |
|
hmm. I'm worried that by merging this, we'd be encouraging client developers to be loose about boost/original IDs in other places as well. |
|
however, since we already do this for boosting posts, maybe there's an argument that we should do it for replies for symmetry |
|
I don't have any strong feelings about this, but I'd like to make some points:
|
|
I'm fine with this. We aren't storing AP objects anyway, it makes sense to change this in the model for our purposes. |
app/models/status.rb
Outdated
| @@ -434,6 +434,9 @@ def set_visibility | |||
| end | |||
|
|
|||
| def set_conversation | |||
| # clients might send the ID of the boost itself instead of the boosted status | |||
There was a problem hiding this comment.
I think this comment is unnecessary
* Ensure replied-to is a status not a boost * Consider case of not a reply * Add test case for replying to boost * Move reblog-reply resolution to model * Remove unnecessary comment
Issue
Fixes #8794
Outline
If the given in-reply-to status is a boost, use the ID of the original status for replying.
To do