Add a tooltip explaining what a locked account is #9403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Dec 1, 2018
| @@ -16,6 +16,7 @@ const messages = defineMessages({ | |||
| unblock: { id: 'account.unblock', defaultMessage: 'Unblock @{name}' }, | |||
| edit_profile: { id: 'account.edit_profile', defaultMessage: 'Edit profile' }, | |||
| linkVerifiedOn: { id: 'account.link_verified_on', defaultMessage: 'Ownership of this link was checked on {date}' }, | |||
| account_locked: { id: 'account.locked_info', defaultMessage: 'This account privacy status is set to locked. The owner manually reviews who can follow them.' }, | |||
There was a problem hiding this comment.
Hey over here, shouldn't be [...] who can follow him. instead of [...] who can follow them. ?
Bye 👋
EDIT : Maybe it was about using a gender neutral pronoun ?
There was a problem hiding this comment.
Yes, it's meant to be gender-neutral
There was a problem hiding this comment.
Sorry for the oversight. Should I make a new PR fixing it?
There was a problem hiding this comment.
Oh, I just realized I read this the other way, I used gender neutral them. Please disregard my comment.
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* create a title tooltip explaining what a locked account is * improve phrasing * minor phrasing fix to unify default and english
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9105 .
Localized to Polish and English.