New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to scrollable lists and media gallery #9501

Merged
merged 5 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@ThibG
Copy link
Collaborator

ThibG commented Dec 11, 2018

Always display a scrollbar for components using ScrollableList, display “load more” whenever some list is known to have more items even if no items have been retrieved so far, and display a loading indicator in account gallery timelines on first load.

ThibG added some commits Dec 11, 2018

Always use the scrollable class for the ScrollList component
Fixes #9499 as well as empty timelines' scrollbar “blinking”
between loading state and empty state.
Fix LoadMore usage in account media gallery
(Even though that codepath is probably never actually used…)
Make account media gallery more consistent with account timeline
Fixes #9498

Display “load more” more consistently, add a loading indicator on first load.
@ykzts

ykzts approved these changes Dec 12, 2018

@Gargron Gargron merged commit 55abff8 into tootsuite:master Dec 12, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment