Ignore low-confidence CharlockHolmes guesses when parsing link cards #9510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/fetch-link-card-charset
branch
from
0e527e7
to
d823ceb
Compare
Gargron
requested changes
Dec 17, 2018
| @@ -137,7 +137,8 @@ def attempt_opengraph | |||
| detector.strip_tags = true | |||
|
|
|||
| guess = detector.detect(@html, @html_charset) | |||
| page = Nokogiri::HTML(@html, nil, guess&.fetch(:encoding, nil)) | |||
| encoding = guess&.fetch(:confidence, 0) > 60 ? guess&.fetch(:encoding, nil) : nil | |||
There was a problem hiding this comment.
I think nil > 60 will throw no method error
There was a problem hiding this comment.
Indeed! Addressed.
Gargron
approved these changes
Dec 17, 2018
|
Thank you, @ThibG! |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…mastodon#9510) * Add failing test for windows-1251 link cards * Ignore low-confidence CharlockHolmes guesses Fixes mastodon#9466 * Fix no method error when charlock holmes cannot detect charset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9466 by ignoring low-confidence
CharlockHolmescharset guesses.High-confidence guesses will still override server or document-specified charset, and low confidence guesses won't be used at all even if there is no server or document-specified charset, so this might not be the best way to proceed.
Note also that the “hint” given to
CharlockHolmesas very little importance, and feeding it the correct charset may not prevent it from outputing an incorrect, low-confidence guess.