New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for avatar image that's too large. #9204 #9518

Merged
merged 7 commits into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@sumdog
Copy link
Contributor

sumdog commented Dec 13, 2018

This should fix #9204.

Notes:

  • I'm not sure if the error message is in the right locale file
  • I couldn't find a way to get the error messages directly off the controller in the test, so I test against the HTML body.

Sumit Khanna added some commits Dec 13, 2018

Show resolved Hide resolved app/services/update_account_service.rb Outdated

Sumit Khanna added some commits Dec 14, 2018

Sumit Khanna
Sumit Khanna
Sumit Khanna

@Gargron Gargron merged commit 769c2d2 into tootsuite:master Dec 14, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment