New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore federated reports targetting already-reported accounts #9534

Merged
merged 1 commit into from Dec 30, 2018

Conversation

Projects
None yet
3 participants
@ThibG
Copy link
Collaborator

ThibG commented Dec 16, 2018

No description provided.

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Dec 16, 2018

So, currently, only the first remote report from a given account targeting a local account is processed.

This means a high-quality report sent after a low-quality one will be lost. It also means that a repeat offender will only get reports from their first offense (indeed, new reports will be ignored if there is an existing report, resolved or not).

This is made worse by the fact that all reports from a same instance will typically be sent from the same account.

@nightpool
Copy link
Collaborator

nightpool left a comment

Thibg's reasoning is sound here, I would like to see this merged. I didn't even realize that the reports I was seeing might be incomplete or not reflect the actual quantity of reports. For example, if someone gets reported for not marking their media as NSFW, and that issue is resolved, then I would never see a report when 6 months later they decide to go on a racist tirade and i need to ban them. This is super exploitable by bad actors.

@Gargron Gargron merged commit b2f4114 into tootsuite:master Dec 30, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment