New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximum visibility of local silenced users to unlisted #9583

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
4 participants
@ThibG
Copy link
Collaborator

ThibG commented Dec 19, 2018

Fixes #9580

@ykzts

ykzts approved these changes Dec 19, 2018

ApplicationRecord.transaction do
status = account.statuses.create!(text: text,
media_attachments: media || [],
thread: in_reply_to,
sensitive: (options[:sensitive].nil? ? account.user&.setting_default_sensitive : options[:sensitive]) || options[:spoiler_text].present?,
spoiler_text: options[:spoiler_text] || '',
visibility: options[:visibility] || account.user&.setting_default_privacy,
visibility: visibility,

This comment has been minimized.

@Gargron

Gargron Dec 20, 2018

Member

This does give away to the user that they are silenced. I thought you want to hook into the ActivityPub-facing JSON to force it there. Although you could argue that they can look at the ActivityPub JSON likewise to find out, so maybe this is the simplest solution...

This comment has been minimized.

@ThibG

ThibG Dec 20, 2018

Author Collaborator

They can already to this by looking at the public timeline of their instance…?
Also, I'm not sure I see the point of silently silencing a local user. Shouldn't a decision about a local user be known to them?

@renatolond

This comment has been minimized.

Copy link
Collaborator

renatolond commented Dec 20, 2018

I think this is a good way to treat this, to limit where their posts can reach. Though I agree it exposes that the user was silenced, and maybe plugging directly into federation code would be better. (but then from other instances they could have the same information, maybe, so 🤷🏽‍♂️)

In my instances I'm always a bit reticent to silence local users. It means I cannot see easily (without going to the admin interface) what they're posting anymore, but they keep posting. This brings the silencing closer to sandboxing, which I think it's what I would want for some cases.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Dec 24, 2018

Okay, now with #9519 communicating "your account is limited" to end-users it makes more sense for this change to limit post visibility in a way that's obvious to those end-users.

@Gargron Gargron merged commit 5f38799 into tootsuite:master Dec 24, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment