/mastodon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined method error in sidekiq #9807

Merged
merged 2 commits into from Jan 14, 2019
+26 −1

Conversation

Reviewers

@Gargron Gargron

@ThibG ThibG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@renatolond @Gargron @ThibG
@renatolond
Copy link
Collaborator

renatolond commented Jan 14, 2019

Body can be not nil but still be empty, which causes a NoMethodError: undefined method []' for nil:NilClass` further in the code. This checks for an empty body to avoid the issue.
@renatolond
Fix undefined method error in sidekiq 
Body can be not nil but still be empty, which causes a
`NoMethodError: undefined method `[]' for nil:NilClass` further in the
code. This checks for an empty body to avoid the issue.
Loading status checks…
8c355dc
@ThibG

ThibG approved these changes Jan 14, 2019
View changes

@renatolond
Fix codeclimate issue
Loading status checks…
ec3d88a
@Gargron

Gargron approved these changes Jan 14, 2019
View changes

@Gargron Gargron merged commit 5c5e14c into tootsuite:master Jan 14, 2019
11 checks passed

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment