Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix slightly cropped font on settings page dropdowns when using system font #9839
Conversation
Gargron
approved these changes
Jan 17, 2019
Gargron
merged commit b8894c4
into
tootsuite:master
Jan 17, 2019
11 checks passed
ci/circleci: build
Your tests passed on CircleCI!
Details
ci/circleci: check-i18n
Your tests passed on CircleCI!
Details
ci/circleci: install
Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4
Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5
Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6
Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4
Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5
Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6
Your tests passed on CircleCI!
Details
ci/circleci: test-webui
Your tests passed on CircleCI!
Details
codeclimate
All good!
Details
ariasuni
deleted the
ariasuni:fix-settings-dropdown-padding
branch
Jan 18, 2019
added a commit
to ThibG/mastodon
that referenced
this pull request
Jan 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ariasuni commentedJan 17, 2019
•
edited
Before/after (using default font — slightly more centered):


Before/after (using system font — much better):

