Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `visibility` param to reblog REST API #9851

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@Gargron
Copy link
Member

Gargron commented Jan 18, 2019

Fix #7322

  • Allow setting visibility for each reblog
  • Changes the default to reblog with the default chosen visibility setting instead of public
  • Use async worker for creating reblog notification to improve performance

@Gargron Gargron added the api label Jan 18, 2019

@Gargron Gargron force-pushed the feature-reblog-visibility-api branch from f59d195 to beeb848 Jan 18, 2019

@Gargron Gargron force-pushed the feature-reblog-visibility-api branch from beeb848 to 87ce030 Feb 21, 2019

@ykzts

ykzts approved these changes Feb 21, 2019

@@ -17,7 +18,7 @@ def call(account, reblogged_status)

return reblog unless reblog.nil?

reblog = account.statuses.create!(reblog: reblogged_status, text: '')
reblog = account.statuses.create!(reblog: reblogged_status, text: '', visibility: options[:visibility] || account.user&.setting_default_privacy)

This comment has been minimized.

@ThibG

ThibG Feb 21, 2019

Collaborator

On the one hand, I'm still uneasy with that change in behavior when we don't have UI to tell the visibility of a boost nor UI to specify it when boosting.
On the other hand, I think it makes more sense than the current behavior…

This comment has been minimized.

@Gargron
Add `visibility` param to reblog REST API
Use async worker for creating reblog notification to improve performance

@Gargron Gargron force-pushed the feature-reblog-visibility-api branch from 87ce030 to 2fa9961 Mar 15, 2019

Most people are okay with reblog visibility following posting visibility preference

@Gargron Gargron merged commit ba84b6d into master Mar 15, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-reblog-visibility-api branch Mar 15, 2019

enewhuis added a commit to BrazosCC/mastodon that referenced this pull request Mar 15, 2019

Add `visibility` param to reblog REST API (tootsuite#9851)
Use async worker for creating reblog notification to improve performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.