-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visibility
param to reblog REST API
#9851
Conversation
f59d195
to
beeb848
Compare
beeb848
to
87ce030
Compare
@@ -17,7 +18,7 @@ def call(account, reblogged_status) | |||
|
|||
return reblog unless reblog.nil? | |||
|
|||
reblog = account.statuses.create!(reblog: reblogged_status, text: '') | |||
reblog = account.statuses.create!(reblog: reblogged_status, text: '', visibility: options[:visibility] || account.user&.setting_default_privacy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the one hand, I'm still uneasy with that change in behavior when we don't have UI to tell the visibility of a boost nor UI to specify it when boosting.
On the other hand, I think it makes more sense than the current behavior…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted a poll: https://mastodon.social/@Gargron/101749616287239685
Use async worker for creating reblog notification to improve performance
87ce030
to
2fa9961
Compare
Most people are okay with reblog visibility following posting visibility preference
Sorry if it's not the place to ask, but will only be activated for new boosts in >=2.8, right ? |
Yes, correct |
And if we want to boost publicly some toot, we have to change the setting, boost, switch back to private visibility by default, and that would work ? |
Use async worker for creating reblog notification to improve performance
Use async worker for creating reblog notification to improve performance
Fix #7322