Add visibility param to reblog REST API
#9851
Conversation
Gargron
force-pushed
the
feature-reblog-visibility-api
branch
from
f59d195
to
beeb848
Compare
Gargron
force-pushed
the
feature-reblog-visibility-api
branch
from
beeb848
to
87ce030
Compare
| @@ -17,7 +18,7 @@ def call(account, reblogged_status) | |||
|
|
|||
| return reblog unless reblog.nil? | |||
|
|
|||
| reblog = account.statuses.create!(reblog: reblogged_status, text: '') | |||
| reblog = account.statuses.create!(reblog: reblogged_status, text: '', visibility: options[:visibility] || account.user&.setting_default_privacy) | |||
There was a problem hiding this comment.
On the one hand, I'm still uneasy with that change in behavior when we don't have UI to tell the visibility of a boost nor UI to specify it when boosting.
On the other hand, I think it makes more sense than the current behavior…
There was a problem hiding this comment.
Posted a poll: https://mastodon.social/@Gargron/101749616287239685
Use async worker for creating reblog notification to improve performance
Gargron
force-pushed
the
feature-reblog-visibility-api
branch
from
87ce030
to
2fa9961
Compare
Gargron
dismissed
ClearlyClaire’s stale review
Most people are okay with reblog visibility following posting visibility preference
|
Sorry if it's not the place to ask, but will only be activated for new boosts in >=2.8, right ? |
|
Yes, correct |
|
And if we want to boost publicly some toot, we have to change the setting, boost, switch back to private visibility by default, and that would work ? |
Use async worker for creating reblog notification to improve performance
Use async worker for creating reblog notification to improve performance
Fix #7322