Don't call upcase! and preserve original values #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upcase!
call is modifying the params passed to the method call, which can be a pain to debug since it's not a clear result. Example:If this is used in an ActiveRecord validation, the upcase value will be passed along and it will be stored in the database as upcase instead of having its original capitalization. Right now I'm using
But it seems like an unnecessary thing to do, a library should never change the values I pass to it unless it's a bang method.