-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility Audit #432
Comments
Here's a CodePen http://codepen.io/majornista/pen/HEkdv that implements changes to the Tab Bar with a little jQuery plugin experiment so that the radio buttons are properly identified as tabs using WAI-ARIA. One important change is to use span rather than button for the tab label. The button becomes another tab stop that receives focus and interferes with a keyboard/screen reader user's operation of the control. |
Love it! |
Actually, if you add the roles, ids, aria-labelledby and aria-controls attributes statically, the only javascript you need to worry about is for the on change event handler, which updates the aria-selected values on the tabs and the aria-hidden and hidden attributes of the tabpanels. You'd need javascript to display the appropriate tabpanel anyway. |
That sounds fine. |
Simplified javascript with mostly static WAI-ARIA attributes: http://cdpn.io/bklzE. Also, for backward compatibility, I use fieldset and a hidden legend labeling the radio button group as a tablist. |
@kristoferjoseph Does Topcoat have a generic label style that assigns the color for use with inputs? Radio button and checkbox labels have color: var-color, but there doesn't seem to be a style for a generic label. |
No, we haven't taken on a generic label yet. Have any suggestions? |
I was just going to add .topcoat__label have it be an inline text element using color: var-color so that it matches the radio button and checkbox label text. There's also a question as to how it should align with the inputs. .reset-input() sets vertical-align: top, which, depending on the input, could look off with inline labels. Positioning of labels can often be application UI specific, so I'm not sure how far you'd want to go with providing classes for different types of positioning. |
Accessibility Aduit
@majornista Was kind enough to walk us through an audit of our demo page http://topcoat.io/topcoat
The text was updated successfully, but these errors were encountered: