Merge pull request #5 from maxceem/develop

fix: error finally() is not a function
topcoder-platform · Oct 31, 2019 · 79ae470 · 79ae470
2 parents 180919b + 4fb7786
commit 79ae470
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/app.js b/src/app.js
@@ -56,10 +56,14 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, (
         throw new Error(`Invalid topic: ${topic}`)
     }
   })()
-  // commit offset regardless of errors
-    .then(() => {})
-    .catch((err) => { logger.logFullError(err) })
-    .finally(() => consumer.commitOffset({ topic, partition, offset: m.offset }))
+    .then(() => {
+      consumer.commitOffset({ topic, partition, offset: m.offset })
+    })
+    .catch((err) => {
+      logger.logFullError(err)
+      // commit offset regardless of errors
+      consumer.commitOffset({ topic, partition, offset: m.offset })
+    })
 })
 
 /**