Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling issues where challenge creation fails #28

Closed
jmgasper opened this issue Jul 11, 2018 · 2 comments
Closed

Handling issues where challenge creation fails #28

jmgasper opened this issue Jul 11, 2018 · 2 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Jul 11, 2018

We have a problem when challenge creation fails, which can happen for various reasons.

If challenge creation fails for a git ticket, then future updates to that ticket also fail because there is no Topcoder challenge associated with the ticket.

Expected functionality

To get around this, we should do the following:

  1. On future updates to the ticket (assignee changed, ticket updated, etc...), we need to check if there is an associated challenge. If there is no associated challenge, we should attempt to create one. If that fails, we will log a new message as a comment on the ticket indicating that challenge creation failed.

  2. We need to ensure that if an OAuth token for a user has expired that we properly refresh it.

Current functionality

Currently, if the challenge creation fails when the ticket is created, all future updates fail when assignees are added or when the ticket is updated or closed.

Validation

For this challenge, you MUST provide clear validation details for both of the items mentioned above.

@jmgasper
Copy link
Collaborator Author

@veshu - In testing this, I see it handled for label editing and unassignment, but I don't see it working for a case where I edit the payment.

For instance, I had an existing ticket and I moved the payment from $75 to $80 and the backing challenge wasn't created.

@veshu
Copy link
Contributor

veshu commented Jul 20, 2018

@jmgasper I couldn't replicate this issue

image

The challenge is created only after 4 minutes for current default configurations.

jmgasper pushed a commit that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants