Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copilot payments: Code quality #58

Closed
jmgasper opened this issue Aug 20, 2018 · 0 comments
Closed

Copilot payments: Code quality #58

jmgasper opened this issue Aug 20, 2018 · 0 comments

Comments

@jmgasper
Copy link
Collaborator

A few issues to clean up:

This flag should be a boolean:
closed: { type: String, required: true, default: "false" }

Should check here for invalid challenge ids:

async function getChallenges() {
... 

const challenges = _.get(response, 'data.result.content');
    logger.debug('Successfully retrieved challenges.');
    return challenges;
  } catch (err) {
 async function getChallengeById(id) {
...  const challenge = _.get(response, 'data.result.content');
    return challenge;
  } catch (er) {
    throw errors.convertTopcoderApiError(er, 'Failed to get challenge details by Id');
  }

Everywhere in file names, you use the term 'Payment' - This should be 'CopilotPayment' so it's fully clear that this is not referring to member payment

@jmgasper jmgasper added this to In progress in September Release Aug 21, 2018
@jmgasper jmgasper moved this from In progress to Done in September Release Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant