Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$50] /home background images #34

Closed
kbowerma opened this issue Jan 5, 2017 · 2 comments
Closed

[$50] /home background images #34

kbowerma opened this issue Jan 5, 2017 · 2 comments

Comments

@kbowerma
Copy link
Contributor

kbowerma commented Jan 5, 2017

Fix the two background in the home component

The banner background image is found at src/routes/Home/components/HomeBanner/HomeBanner.scss and it is using a relative path to get the banner-bg-.png incorrectly. Also How it works had the same problem.

This problem only occurs when you run npm run dev locally. If you run npm run start the banner will work but the other drone images wont.

however when I deploy to Heroku they both seem to work fine.

Please fix this reference link in the corresponding scss and do a PR or let me know what is wrong with my process.

image

@kbowerma kbowerma self-assigned this Jan 5, 2017
@kbowerma kbowerma removed their assignment Jan 5, 2017
@kbowerma kbowerma changed the title /home images [$50] /home background images Jan 5, 2017
@lstkz lstkz self-assigned this Jan 13, 2017
@lstkz
Copy link
Collaborator

lstkz commented Jan 13, 2017

You removed this line

    publicPath: __DEV__ ? `http://${ip.address()}:${process.env.PORT || 3000}/` : '/',

in
d08f40e

This is not correct. When you deploy to Heroku you should always use NODE_ENV=production

gondzo added a commit that referenced this issue Jan 14, 2017
@kbowerma
Copy link
Contributor Author

kbowerma commented Feb 1, 2017

Payment Scheduled - DRONESERIES-6

@kbowerma kbowerma closed this as completed Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants