Makes sure `gam' method can generate grid of length 1. #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `gam' method gives an error if passed with trainControl(method = "none"). You can see the error here: rm( list = ls()) n <- 1e3 x <- cbind(x = rnorm(n)) y <- c(x + rnorm(n)) train(x, y, method = "gam", trControl = trainControl(method = "none")) # Error: Only one model should be specified in tuneGrid with no resampling Note that the default behavior of `trainControl(method = "none")` is to create a grid of length 1. However, here the minimal grid it was creating always had length 2, as it was passing both TRUE and FALSE to the parameter `select,' which does not make sense if we want a grid of length 1. The proposed change makes sure expand.grid will always have length 1, if len = 1.
carloscinelli
changed the title
|
@carloscinelli thanks for these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the `gam' method gives an error if passed with trainControl(method = "none"). You can see the error here:
Note that the default behavior of
trainControl(method = "none")is to settuneLength = 1and thus create a grid of length 1.However, here the minimal grid it was creating always had length 2, as it was passing both TRUE and FALSE to the parameter `select,' which does not make sense if we want a grid of length 1.
The proposed change makes sure expand.grid will always have length 1, if len = 1.
(and this does not affect the behavior of anything else whenever len > 1)