-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing exports required for some foreach backend #748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 16.97% 16.97%
=======================================
Files 90 90
Lines 13187 13187
=======================================
Hits 2238 2238
Misses 10949 10949 Continue to review full report at Codecov.
|
I had the same problem using doMPI on a cluster of two nodes (localhost and one remote computer) |
OK. It looks like my list should be enlarged... |
I had a similar issue with doAzureParallel, it seems that all of the internal functions will need to be |
Experimenting with foreach, it seems that forcing to load caret with the .packages option helps. Can you help me checking this is indeed the case by sending a reproducible example or testing the proposed modification? |
I ran one of our samples codes. Installed your branch, It works for me. library(DAAG) set.seed(998) fitControl <- trainControl(## 10-fold cross validation rf_fit <- train( rf_fit |
Thanks for fixing this. I run a bunch of tests using |
@brnleehng have you tested these updates on @lepennec Anything else that you think needs to happen? |
I expect that if we cover sufficient different backends, which seems to be the case, we should not have more surprise... |
I've stumbled upon a bug for some foreach backend (doFuture with multisession for instance...). There are some missing exports in workflows.R. It seems that completing the list as proposed below fix this issue.