Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2D led spectrum analyser - (remix) #3

Merged
merged 1 commit into from Jun 1, 2015

Conversation

un1versal
Copy link

Best reviewed with ?w=1 un1versal@82c6602?w=1

See http://forum.kodi.tv/showthread.php?tid=204991&pid=2011733#pid2011733

Can be seen in action at https://www.shadertoy.com/view/Mlj3WV#

I tried to match it as closely to the request in forums http://forum.kodi.tv/showthread.php?tid=204991&pid=1799716#pid1799716

This is as close as I could get hacking around with this, maybe @topfs2 or somone can give me a few pointers and see if I can indeed get it to exact match (i.e the trailing grey peak indicators) which would make this extra nice.

It works a treat in Kodi (My wife and other women in family all agreed)

Some screenshots for an idea.

screenshot015
screenshot017
screenshot018
screenshot019

@un1versal un1versal changed the title add led spectrum analyser (modified) add led spectrum analyser (remix) May 25, 2015
@un1versal un1versal force-pushed the ledspectrum branch 3 times, most recently from 9a3e5c8 to 0e10d1f Compare May 26, 2015 09:54
@kib
Copy link

kib commented May 26, 2015

There is something wonky going on with your commits there. Check the diff :)

Otherwise: nice addition !

@un1versal un1versal force-pushed the ledspectrum branch 3 times, most recently from 71676e1 to a95ca3c Compare May 27, 2015 11:05
@un1versal un1versal changed the title add led spectrum analyser (remix) add 2D led spectrum analyser - (remix) May 27, 2015
@un1versal un1versal force-pushed the ledspectrum branch 4 times, most recently from d12dcf0 to 82c6602 Compare May 28, 2015 23:37
@topfs2
Copy link
Owner

topfs2 commented Jun 1, 2015

The wonkyness is fixed now right? It looks nice afaict now? Just making sure before I merge :)

@topfs2
Copy link
Owner

topfs2 commented Jun 1, 2015

Oh and regarding the trailing peak trails I don't think you can accomplish it with the data we upload, we would need to upload peak history as a separate texture. I guess we could do that but ideally I'd like to follow the shadertoy API as much as possible, but perhaps we could open up a dialog with them and perhaps they'd be interested in adding it to theirs too. I know they have 2x512 texture for audio, and we could have peak history in one row. But I think some shaders utilize the linear fading of that row so would need some changes.

@un1versal
Copy link
Author

Well Ive no idea what wonkiness it was or whatever it was meant by that commnet, god bless vague comments.

Its rebased and pushed ready for merge.

regarding the peak history, its not important, it would be nice all in one shader but Ive no idea how to achieve that currently even if shadertoy api supported it.

topfs2 added a commit that referenced this pull request Jun 1, 2015
add 2D led spectrum analyser - (remix)
@topfs2 topfs2 merged commit a202550 into topfs2:master Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants