thread id obtained on each event to ensure it is accurate #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caching the id doesnt always provide correct results (it assumes that the app creates an instance of Hodel3000CompliantLogger per thread) In jruby, the actual OS thread ID can be obtained from JRuby.reference(Thread.current).native_thread.id however Thread.curent.object_id is a sufficient proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caching the id doesn't always provide correct results (it assumes that
the app creates an instance of Hodel3000CompliantLogger per thread)
In jruby, the actual OS thread ID can be obtained from
JRuby.reference(Thread.current).native_thread.id
however Thread.curent.object_id is a sufficient proxy